Make MethodUtils CACHE_METHODS volatile (1.X)#416
Merged
garydgregory merged 1 commit intoJul 13, 2026
Conversation
written under the class monitor but read lock-free in getCachedMethod and cacheMethod, so setCacheMethods(false) may not be visible to other threads
7 tasks
garydgregory
added a commit
that referenced
this pull request
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #414 to the
1.Xbranch.setCacheMethodswritesCACHE_METHODSunder the class monitor butgetCachedMethodandcacheMethodread it lock-free on the method-lookup path, so a runtimesetCacheMethods(false)may never be observed by other threads and they keep populating and reading the shared staticcache; marking the fieldvolatilerestores cross-thread visibility while writes stay synchronized so the flag flip andclearCache()remain atomic.Same caveat as #414: a memory-visibility fix has no deterministic unit test, so none is added.
mvn test -Dtest=MethodUtilsTestis green. The full default goal hits one failure inLocaleBeanificationTest.testContextClassloaderIndependenceon my machine, but it fails identically on unmodified1.Xand passes standalone, so it is pre-existing and unrelated to this change.mvn; that'smvnon the command line by itself.