Skip to content

Make MethodUtils CACHE_METHODS volatile (1.X)#416

Merged
garydgregory merged 1 commit into
apache:1.Xfrom
rootvector2:methodutils-cache-volatile-1.x
Jul 13, 2026
Merged

Make MethodUtils CACHE_METHODS volatile (1.X)#416
garydgregory merged 1 commit into
apache:1.Xfrom
rootvector2:methodutils-cache-volatile-1.x

Conversation

@rootvector2

Copy link
Copy Markdown
Contributor

Port of #414 to the 1.X branch.

setCacheMethods writes CACHE_METHODS under the class monitor but getCachedMethod and cacheMethod read it lock-free on the method-lookup path, so a runtime setCacheMethods(false) may never be observed by other threads and they keep populating and reading the shared static cache; marking the field volatile restores cross-thread visibility while writes stay synchronized so the flag flip and clearCache() remain atomic.

Same caveat as #414: a memory-visibility fix has no deterministic unit test, so none is added. mvn test -Dtest=MethodUtilsTest is green. The full default goal hits one failure in LocaleBeanificationTest.testContextClassloaderIndependence on my machine, but it fails identically on unmodified 1.X and passes standalone, so it is pre-existing and unrelated to this change.

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

written under the class monitor but read lock-free in getCachedMethod and cacheMethod, so setCacheMethods(false) may not be visible to other threads
@garydgregory garydgregory changed the title make MethodUtils CACHE_METHODS volatile (1.X) Make MethodUtils CACHE_METHODS volatile (1.X) Jul 13, 2026
@garydgregory garydgregory merged commit 3e7ebea into apache:1.X Jul 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants