Case-fold column and bean property names with Locale.ROOT (1.X)#417
Merged
Merged
Conversation
port of apache#415: default-locale toLowerCase/toUpperCase mangle identifiers under a Turkish locale (column ID becomes a property with a dotless i, and getImages is rebuilt with a dotted I); fold with Locale.ROOT in JDBCDynaClass and DefaultBeanIntrospector. the regression test uses @DefaultLocale from junit-pioneer per review feedback on apache#415, added as a test dependency (1.9.1, the last Java 8 compatible line).
7 tasks
garydgregory
added a commit
that referenced
this pull request
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #415 to 1.X.
JDBCDynaClass.createDynaPropertyfolds JDBC column names to lower case withString.toLowerCase(), andDefaultBeanIntrospector.handleIndexedPropertyDescriptorsupper-cases the first letter of an indexed property name withString.toUpperCase(), both using the default locale. Under a Turkish locale"ID".toLowerCase()is"ıd"(dotless i), so a columnIDmaps to propertyıdandgetDynaProperty("id")returnsnull; the introspector likewise rebuilds an indexed accessor asgetİmagesinstead ofgetImages. Both now fold withLocale.ROOT, same as the fix merged on master.Per the review on #415, the regression test uses
@DefaultLocalefrom JUnit Pioneer instead of saving and restoring the default locale by hand; junit-pioneer 1.9.1 (the last Java 8 compatible line) is added as a test dependency. The test fails on1.Xwithout the runtime change and passes with it.Note:
mvn teston a clean1.Xcheckout failsLocaleBeanificationTest#testContextClassloaderIndependencein my environment (it passes in isolation and CI on1.Xis green), so I could not get a fully green default-goal run locally; the failure is identical with and without this change.mvn; that'smvnon the command line by itself.