Fix Flat3Map entrySet remove ignoring the entry value#714
Merged
garydgregory merged 3 commits intoJul 17, 2026
Conversation
EntrySet.remove deleted on a key match alone; guard with contains(obj) so only a full key-and-value match removes, matching AbstractHashedMap.
Member
|
Good one @rootvector2 , will merge 🚀 . We have many of these types of types which may suffer from the same issue. Would you please check other Maps? TY! In the future, don't edit |
garydgregory
added a commit
that referenced
this pull request
Jul 17, 2026
Contributor
Author
|
went through the other |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noticed
Flat3Map.EntrySet.removediverges fromAbstractHashedMap: it removes on a key match alone, soentrySet().remove(entry)drops a mapping even when the entry value differs; guard withcontains(obj)so only a full key-and-value match removes.mvn; that'smvnon the command line by itself.