CRYPTO-30: Mutable fields should be private - #19
Closed
winningsix wants to merge 1 commit into
Closed
Conversation
winningsix
changed the title
winningsix
force-pushed
the
CRYPTO-30
branch
2 times, most recently
from
April 27, 2016 06:50
64f5759 to
079f603
Compare
winningsix
changed the title
| * Set the IV. | ||
| * | ||
| * @param iv the IV. | ||
| */ |
Contributor
There was a problem hiding this comment.
Do we really need setIv method? it is passed in constructor and we may don't need to change it.
Contributor
|
Xianda has a bigger change to refine the parameters. So you keep work after Xianda's code merge or for time, we can work based on his code to avoid conflicts. |
winningsix
force-pushed
the
CRYPTO-30
branch
4 times, most recently
from
April 28, 2016 08:01
47f7fce to
079372a
Compare
Contributor
|
+1 |
Contributor
Author
|
Thanks @jerrychenhf for your review. Committed to the upstream at 98bec4c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mutable fields should be private or possibly package-protected, never protected or public.