Fix int overflow in FluentBitSet.setInclusive at Integer.MAX_VALUE#1751
Merged
garydgregory merged 1 commit intoJul 17, 2026
Merged
Conversation
garydgregory
added a commit
that referenced
this pull request
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro:new FluentBitSet().setInclusive(0, Integer.MAX_VALUE)throwsIndexOutOfBoundsException: toIndex < 0: -2147483648, and so doessetInclusive(Integer.MAX_VALUE, Integer.MAX_VALUE).Cause:setInclusiveconverts the inclusivetoIndexintoBitSet.set's exclusive upper bound withtoIndex + 1, which overflows toInteger.MIN_VALUEwhentoIndexisInteger.MAX_VALUE. The Javadoc only documents a throw when an index is negative orfromIndexis larger thantoIndex, so a legal top-of-range call throws instead of setting the bits.Fix:special-casetoIndex == Integer.MAX_VALUEso the range and the top bit are set without the overflowing increment; every other input keeps the existing singlesetcall. The regression test is guarded by@EnabledIfSystemProperty(named = "test.large.heap", matches = "true")like the existing large-heap test, since bitInteger.MAX_VALUEneeds the full backing array; it fails on the current code and passes with the fix.