Fix TypeUtils.isAssignable() for wildcards with multiple upper bounds - #1782
Open
Alwaysgaurav1 wants to merge 1 commit into
Open
Fix TypeUtils.isAssignable() for wildcards with multiple upper bounds#1782Alwaysgaurav1 wants to merge 1 commit into
Alwaysgaurav1 wants to merge 1 commit into
Conversation
Contributor
Author
|
@garydgregory, please review it quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue in
TypeUtils.isAssignable(Type, WildcardType, Map)where checking assignability of aWildcardTypewith multiple upper bounds (intersection types such as? extends Serializable & Cloneable) to anotherWildcardType(such as? extends Serializable) incorrectly returnedfalse.Root Cause
When the subject
typeis aWildcardType, the upper bounds loop previously enforced that every upper bound in the subject wildcard had to be assignable to each target upper boundtoBound(forall bound in upperBounds: isAssignable(bound, toBound)):