[NET-745] Clarify UnixFTPEntryParser trimLeadingSpaces in Javadoc#405
Merged
garydgregory merged 2 commits intoJul 22, 2026
Conversation
Updated comments to clarify handling of leading spaces in file names.
garydgregory
added a commit
that referenced
this pull request
Jul 22, 2026
space when listing contains a year instead of time (IBM i example) (#405). Sort members.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnixFTPEntryParser preserves leading spaces in filenames by default, since Unix filenames can legitimately start with spaces. However, some FTP servers (including IBM i / OS/400 returning Unix-style listings) pad the date column with extra spaces when showing a year instead of a time for older entries, causing filenames to have an unintended leading space.
This was reported on the dev mailing list and tracked as NET-745. The trimLeadingSpaces constructor option (added in 3.4) fixes it, but the class Javadoc did not mention this behavior or the workaround.
This PR adds a paragraph to the class Javadoc explaining the issue and pointing to the trimLeadingSpaces constructor.
Resolves NET-745.