Merge the static hardening recipes into the public factory classes - #56
Merged
Merged
Conversation
Each public Hardening*Factory absorbs its package-private hardener (DocumentBuilderHardener and siblings): the harden methods, helpers and constants move onto the entry point, the hardener files are deleted, and the wrap methods are removed since each wrapper is now constructed from its own class only. On HardeningSAXParserFactory the reader and source variants become harden(XMLReader) and harden(Source) overloads. Assisted-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WWJ4LAxx3TX5RwNvwKbAS3
Member
Author
|
This was intentionally pushed to this repository, so I can stack another PR on top. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each public
Hardening*Factoryabsorbs its package-private hardener (DocumentBuilderHardenerand siblings): the harden methods, helpers and constants move onto the entry point, the hardener files are deleted, and the wrap methods are removed since each wrapper is now constructed from its own class only.On
HardeningSAXParserFactorythe reader and source variants are renamed toharden(XMLReader)andharden(Source)overloads.Assisted-By: Claude Fable 5 noreply@anthropic.com