Reclassify the JAXP 1.5 accessExternal properties as modifiable - #65
Merged
garydgregory merged 1 commit intoAug 31, 2026
Merged
Conversation
The securing is independent of the JAXP 1.5 external-access properties: a resource supplied by a resolver bypasses their checks, and the resolver floor covers every external reference, so no value a caller sets loosens the securing and no value is needed to keep it. Move the three properties from the reserved list to "Settings you may modify" in the threat model, add a Javadoc overview section explaining why the securing does not build on them, and add AccessExternalPropertyTest guarding that loosening them to "all" on a secured factory does not reopen an external fetch. Assisted-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014Hm8EbPnSdQeuQfsoFwQt1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The securing is independent of the JAXP 1.5 external-access properties (
accessExternalDTD,accessExternalSchema,accessExternalStylesheet): by specification, a resource supplied by a registered resolver bypasses their checks, and the resolver floor covers every external reference. No value a caller sets loosens the securing, and no value is needed to keep it — the known JDK defects that apply the checks even to resolver-supplied documents all fail closed.This change therefore:
AccessExternalPropertyTest, which loosens each property toallon a secured factory and asserts the external fetch still does not happen, across DOM, SAX, schema compilation and TrAX;AttackTestSupportwith caller-configured-factory overloads of the existing no-leak assertions, and fixes a fewThesecuringtypos in the threat model.Tests pass across the full surefire implementation matrix; implementations that reject the properties (no knob to loosen) skip via assumptions.
🤖 Generated with Claude Code
https://claude.ai/code/session_014Hm8EbPnSdQeuQfsoFwQt1