Refactor: surface static-init failures as ExceptionInInitializerError - #51
Merged
garydgregory merged 3 commits intoAug 26, 2026
Merged
Conversation
The JVM wraps any exception thrown during static initialization in ExceptionInInitializerError, so the HardeningException wrapper in the two resolver floors never reached callers as IllegalStateException. The helpers now declare the checked exceptions they naturally throw, and the static initializer rethrows ExceptionInInitializerError directly. Assisted-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Jvd3SdALeiMvRPBe3Y7Cdp
…error-wrapping # Conflicts: # src/main/java/org/apache/commons/xml/FallbackIgnoreURIResolver.java
garydgregory
changed the title
Member
|
Ah, crud, the GH conflict resolution I tried bombed. |
garydgregory
added a commit
that referenced
this pull request
Aug 26, 2026
ExceptionInInitializerError- #51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JVM wraps any exception thrown during static initialization in
ExceptionInInitializerError, so theHardeningExceptionwrapper in the two resolver floors never reached callers asIllegalStateException. The helpers now declare the checked exceptions they naturally throw, and the static initializer rethrowsExceptionInInitializerErrordirectly.These exceptions are very unlikely to ever occur, but if they occur, they'll have one less level of nesting.