Improving Android build output and verbose logging#305
Closed
riknoll wants to merge 3 commits intoapache:masterfrom
MSOpenTech:better-output
Closed
Improving Android build output and verbose logging#305riknoll wants to merge 3 commits intoapache:masterfrom MSOpenTech:better-output
riknoll wants to merge 3 commits intoapache:masterfrom
MSOpenTech:better-output
Conversation
Contributor
|
|
Contributor
Author
|
Sorry @jasongin, I made a few more updates. Mind taking a look? |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improving grammar, consistency of language, detail, etc. for verbose and regular output. I'm going to use Android as an example for Windows and iOS to follow. There wasn't much that was missing log-wise, mostly just needed to be clearer about what was happening. The changes in #295 will also improve output a lot (though they might conflict with this PR a bit). Also see apache/cordova-lib#439