Skip to content

[iOS] install ios-deploy in correct way & add missing CocoaPods tools…#1103

Closed
mosabab wants to merge 1 commit intoapache:masterfrom
mosabab:patch-1
Closed

[iOS] install ios-deploy in correct way & add missing CocoaPods tools…#1103
mosabab wants to merge 1 commit intoapache:masterfrom
mosabab:patch-1

Conversation

@mosabab
Copy link
Contributor

@mosabab mosabab commented Aug 5, 2020

[iOS] install ios-deploy in correct way & add missing information regarding CocoaPods tools that needed to build iOS apps.

Platforms affected

iOS

Motivation and Context

  • How to install ios-deploy tool in correct way.
  • Add missing information about CocoaPods tools that needed to build iOS apps.

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek
Copy link
Contributor

breautek commented Aug 5, 2020

I think this PR should be actually two separate PRs.

One change for the CocoaPods update, the other for the ios-deploy update. Otherwise I think they are good.

@mosabab
Copy link
Contributor Author

mosabab commented Aug 5, 2020

I think this PR should be actually two separate PRs.

One change for the CocoaPods update, the other for the ios-deploy update. Otherwise I think they are good.

I was close the 2 separated PRs in the following:
#1095
#1102

This PR merge the 2.

Feel free to reopen the closed 2 PRs. And close this one. what do you think ?

@breautek
Copy link
Contributor

breautek commented Aug 5, 2020

#1095 appears to be a copy of this one?

https://github.com/apache/cordova-docs/pull/1102/files looks good as is, I'll reopen that one.

edit: err I can't reopen the PR because the remote has been deleted.

@mosabab
Copy link
Contributor Author

mosabab commented Aug 5, 2020

#1095 appears to be a copy of this one?

https://github.com/apache/cordova-docs/pull/1102/files looks good as is, I'll reopen that one.

edit: err I can't reopen the PR because the remote has been deleted.

I will make new 2 separated PR for this .

@mosabab mosabab closed this Aug 5, 2020
@mosabab
Copy link
Contributor Author

mosabab commented Aug 5, 2020

Close this one.

And open 2 new separated PR:
#1104
#1105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants