Skip to content

[iOS] Add missing information regarding CocoaPods#1105

Merged
breautek merged 2 commits intoapache:masterfrom
mosabab:patch-3
Aug 5, 2020
Merged

[iOS] Add missing information regarding CocoaPods#1105
breautek merged 2 commits intoapache:masterfrom
mosabab:patch-3

Conversation

@mosabab
Copy link
Contributor

@mosabab mosabab commented Aug 5, 2020

Platforms affected

iOS

Motivation and Context

[iOS] Add missing information regarding CocoaPods.

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe have the message like this?

In the latest release for Cordova-iOS 6.x, which these docs are aiming for, it has a requirement that CocaPods has to be 1.8.0 or greater.

@mosabab
Copy link
Contributor Author

mosabab commented Aug 5, 2020

Maybe have the message like this?

In the latest release for Cordova-iOS 6.x, which these docs are aiming for, it has a requirement that CocaPods has to be 1.8.0 or greater.

You are right, but this is information of the documentation for iOS, and I think there is no need to specify the version in the main documentation like ios-deploy, because the installation code sudo gem install cocoapods will install the latest stable version which is for now 1.9.3 which is > 1.8.0

And you can always specify the minimum version requirements in the new cordova-ios releases.

Anyway, your suggest seems good to include.

Co-authored-by: エリス <erisu@users.noreply.github.com>
@mosabab mosabab requested a review from erisu August 5, 2020 13:41
@breautek
Copy link
Contributor

breautek commented Aug 5, 2020

Tests passed, thank you for your contribution @mosabab ! 🎉

@breautek breautek merged commit 453cc81 into apache:master Aug 5, 2020
purplecabbage pushed a commit that referenced this pull request Oct 15, 2020
* [iOS] Add missing information regarding CocoaPods

* Update www/docs/en/dev/guide/platforms/ios/index.md

Co-authored-by: エリス <erisu@users.noreply.github.com>

Co-authored-by: エリス <erisu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants