fix(ios): copyTo should overwrite any existing file (CB-6938) #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmaj
reviewed
Jul 23, 2017
Contributor
filmaj
left a comment
filmaj
left a comment
There was a problem hiding this comment.
Took a look, we should probably add a case handling the failure. As well, what can we do to add test coverage for this behaviour? Just so we don't regress in the future.
| // first try to remove the existing file | ||
| bSuccess = [fileMgr removeItemAtPath:newFileSystemPath error:&error]; | ||
|
|
||
| if (bSuccess) { |
Contributor
There was a problem hiding this comment.
What should be done in the case removal of the item fails?
Member
|
Hey, I just fixed the problem that caused Android tests to fail in |
janpio
changed the title
Member
|
Rerun with current test configuration. |
Member
|
CI: Once more please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CB-6938
Platforms affected
iOS, all versions.
What does this PR do?
It fixes CB-6938.
Instead of returning an error 12 (PATH_EXISTS_ERR), it tries to remove the existing file, then to copy the "new" one.
What testing has been done on this change?
Simulator: iPhone 5 and iPhone 6 @ iOS 9, 10.
Real device: iPhone 5 @ iOS 10.
No unit test provided nor written.
Checklist