Skip to content

fix(ios): copyTo should overwrite any existing file (CB-6938) #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VinceOPS wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ios): copyTo should overwrite any existing file (CB-6938) #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/ios/CDVLocalFilesystem.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,8 +551,13 @@ - (void)copyFileToURL:(CDVFilesystemURL *)destURL withName:(NSString *)newName f
// can't copy dir into self
errCode = INVALID_MODIFICATION_ERR;
} else if (bNewExists) {
// the full destination should NOT already exist if a copy
errCode = PATH_EXISTS_ERR;
// first try to remove the existing file
bSuccess = [fileMgr removeItemAtPath:newFileSystemPath error:&error];

if (bSuccess) {
Copy link
Contributor

@filmaj filmaj Jul 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should be done in the case removal of the item fails?

// then copy the new one
bSuccess = [fileMgr copyItemAtPath:srcFullPath toPath:newFileSystemPath error:&error];
}
} else {
bSuccess = [fileMgr copyItemAtPath:srcFullPath toPath:newFileSystemPath error:&error];
}
Expand Down