This repository was archived by the owner on Oct 17, 2022. It is now read-only.
Conversation
ghost
changed the title
Contributor
|
Good catch. Make check fails because a line is longer than 80 characters. Also make sure to rebase on master and make it one commit (I see 4 currently). |
flimzy
reviewed
Jul 17, 2018
|
|
||
| The message below indicates that the operating system is running in "FIPS mode," | ||
| which among other restrictions does not allow the use of OpenSSL's MD5 funtions: | ||
| which among other restrictions does not allow the use of OpenSSL's MD5 functions: |
Member
There was a problem hiding this comment.
Optional, but while you're correcting the sentence, you could also add commas around the subordinate clause:
which, among other restrictions, does not...
added 2 commits
July 17, 2018 10:26
Author
Contributor
|
Looks great @rokek. Thank you again for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct a misspelling.