Switch away from passing funs between nodes when uploading attachments#1393
Closed
nickva wants to merge 1 commit into
Closed
Switch away from passing funs between nodes when uploading attachments#1393nickva wants to merge 1 commit into
nickva wants to merge 1 commit into
Conversation
Member
|
I can't review the code here, but I insist you add something to the documentation about this new flag, even if it's just in Speaking of which, I don't see any changes in this PR to that file 😞 ALL new When we change the default value and remove the config option, we will need a big screaming warning in the upgrade docs that says rolling upgrades from older CouchDBs that have the value set to |
nickva
force-pushed
the
do-not-pass-funs-between-nodes
branch
from
June 19, 2018 19:39
bb3db59 to
d569d24
Compare
Contributor
Author
|
@wohali sorry, this is still a WIP, forgot to mark it as such |
Passing closures around is fragile and prevents smooth upgrading. Instead pass a tuple with a data from the receiver closure explicitly and convert to back to a local fun locally on each node.
nickva
force-pushed
the
do-not-pass-funs-between-nodes
branch
from
June 19, 2018 20:15
d569d24 to
2419b22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing closures around is fragile and prevents smooth upgrading. Instead pass
a tuple with a data from the receiver closure explicitly and convert to back to
a local fun locally on each node.
Config options
[fabric] attachment_receiver_tuplecontrols how receivers areencoded. To upgrade a cluster to use the new format, first upgrade all nodes to
the new code, then flip the value to
true. In the future, the option and theold closure handling code will be removed.