A better fix for handling node local 413 responses - #1403
Merged
nickva merged 1 commit intoJun 22, 2018
Merged
Conversation
During 21.0 testing, the hack to read extra data from the socket to give the client a better chance of detecting a 413 response ended up failing. Either process scheduling or IO scheduling was different enough that the test started failing fairly consistently. Apply a better fix that's more in-line with the intent -- after responding to the client with a 413, read a limited amount of data off the socket (1MB). Limit the maximum time spent doing it to less than 1 second. Issue apache#1396
eiri
approved these changes
Jun 22, 2018
eiri
left a comment
eiri
left a comment
Member
There was a problem hiding this comment.
That 1Mb drain is it arbitrary? In this case is it 100 times better than reading 10k? :)
+1 anyhow, this looks less hacky than attempt to read nothing in no time.
Contributor
Author
|
@eiri thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During 21.0 testing, the hack to read extra data from the socket to give the
client a better chance of detecting a 413 response ended up failing. Either
process scheduling or IO scheduling was different enough that the test started
failing fairly consistently.
Apply a better fix that's more in-line with the intent -- after responding to
the client with a 413, read a limited amount of data off the socket (1MB).
Limit the maximum time spent doing it to less than 1 second.
Issue #1396