Skip to content

Drop Erlang R16 support#1427

Merged
wohali merged 2 commits into
masterfrom
drop-r16
Jul 13, 2018
Merged

Drop Erlang R16 support#1427
wohali merged 2 commits into
masterfrom
drop-r16

Conversation

@janl

@janl janl commented Jul 9, 2018

Copy link
Copy Markdown
Member

No description provided.

@janl janl added the discussion label Jul 9, 2018
@janl janl added this to the 2.2.0 milestone Jul 9, 2018
@janl
janl requested review from chewbranca, davisp, rnewson and wohali July 9, 2018 14:12
@wohali

wohali commented Jul 9, 2018

Copy link
Copy Markdown
Member
  1. remove this line from .travis.yml
  2. this breaks Jenkins, because Step 1 (which builds the dist tarball) runs in couchdbdev/ubuntu-trusty-erlang-default which is 16B03.

I need to build a new Docker container that has R17 in it instead, a couchdbdev/ubuntu-trusty-erlang-17.XX.XX using packages from erlang-solutions. This will be minor changes to apache/couchdb-ci and a docker push after the fact.

Please hold on merging this until that's done and I can run a jenkins test. I hope to get to it later today.

@wohali wohali left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@janl

janl commented Jul 9, 2018

Copy link
Copy Markdown
Member Author

Please hold on merging this until that's done and I can run a jenkins test.

You’ve got it.

@janl

janl commented Jul 9, 2018

Copy link
Copy Markdown
Member Author

remove this line from .travis.yml

Done.

@janl
janl removed the request for review from chewbranca July 10, 2018 08:21
@janl janl removed this from the 2.2.0 milestone Jul 10, 2018
@wohali

wohali commented Jul 13, 2018

Copy link
Copy Markdown
Member

@janl I'm building the image today - and will do a separate push to an updated Jenkinsfile to master so that this PR won't break the build. I'll update back when ready.

+1 to dropping 16B03* support.

@wohali wohali added this to the 2.2.0 milestone Jul 13, 2018
@wohali

wohali commented Jul 13, 2018

Copy link
Copy Markdown
Member

We'll make it for 2.2.0.

@wohali

wohali commented Jul 13, 2018

Copy link
Copy Markdown
Member

Once #1438 lands this can merge.

@wohali

wohali commented Jul 13, 2018

Copy link
Copy Markdown
Member

As to the discussion part, I know @rnewson was ready to drop 16B03 a long while ago, and there was general agreement on IRC that this is "the right thing to do." Since packages no longer rely on the system-provided Erlang, there is little motivation for us to support really old Erlangs anyway...but shifting to a "you need {latest|latest-1} Erlang release" approach is probably best saved for a 3.0 IMO.

@nickva

nickva commented Jul 13, 2018

Copy link
Copy Markdown
Contributor

+1

@wohali
wohali merged commit 0f130cb into master Jul 13, 2018
@wohali
wohali deleted the drop-r16 branch July 13, 2018 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants