Switch fabric attachment reciever to use messages instead of function closures - #1452
Merged
nickva merged 1 commit intoJul 17, 2018
Merged
Conversation
Function closures are fragile and attachment uploads would break if fabric_doc_attachments is different on any of the nodes in a cluster, like it might happen during a roling cluster upgrade. Previously fe53e43 introduced two versions of the module one which handles function closure, other which handled message but only in this commit messages are starting to be sent. To avoid breakages in attachemnt uploads during the period of a rolling cluster upgrade, make sure to upgrade to that commit first then upgrade to this change. Issue #1394
nickva
deleted the
switch-fabric-to-use-message-based-attachment-receiver
branch
July 17, 2018 20:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function closures are fragile and attachment uploads would break if
fabric_doc_attachments is different on any of the nodes in a cluster, like it
might happen during a roling cluster upgrade.
Previously fe53e43 introduced two versions of
the module one which handles function closure, other which handled message but
only in this commit messages are starting to be sent.
To avoid breakages in attachemnt uploads during the period of a rolling cluster
upgrade, make sure to upgrade to that commit first then upgrade to this change.
Issue #1394