Skip to content

Avoid badmatch when getting fabric timeout - #1739

Merged
jiangphcn merged 1 commit into
masterfrom
timeout-_purged_infos_limit
Nov 16, 2018
Merged

Avoid badmatch when getting fabric timeout#1739
jiangphcn merged 1 commit into
masterfrom
timeout-_purged_infos_limit

Conversation

@jiangphcn

Copy link
Copy Markdown
Contributor

Overview

Avoid badmatch when putting _set_purge_infos_limit and getting fabric timeout

Testing recommendations

======================== EUnit ========================
module 'chttpd_purge_tests'
  chttpd db tests
Application crypto was left running!
    chttpd_purge_tests:87: test_empty_purge_request...[0.009 s] ok
    chttpd_purge_tests:104: test_ok_purge_request...[0.285 s] ok
    chttpd_purge_tests:141: test_accepted_purge_request...[0.123 s] ok
    chttpd_purge_tests:173: test_partial_purge_request...[0.084 s] ok
    chttpd_purge_tests:209: test_mixed_purge_request...[0.172 s] ok
    chttpd_purge_tests:257: test_overmany_ids_or_revs_purge_request...[0.130 s] ok
    chttpd_purge_tests:307: test_exceed_limits_on_purge_infos...[0.140 s] ok
    chttpd_purge_tests:350: should_error_set_purged_docs_limit_to0...[0.004 s] ok
    chttpd_purge_tests:358: test_timeout_set_purged_infos_limit...[0.087 s] ok
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed
    [done in 3.567 s]
  [done in 5.743 s]
=======================================================
  All 9 tests passed.

Related Issues or Pull Requests

COUCHDB-3326

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

@jiangphcn
jiangphcn requested a review from davisp November 15, 2018 01:52

@davisp davisp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

   - Avoid badmatch when putting set_purge_infos_limit
     and getting fabric timeout

COUCHDB-3326
@jiangphcn
jiangphcn force-pushed the timeout-_purged_infos_limit branch from c2be3c9 to 6da9b71 Compare November 15, 2018 23:02
@jiangphcn
jiangphcn merged commit fedea84 into master Nov 16, 2018
@nickva
nickva deleted the timeout-_purged_infos_limit branch December 18, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants