Skip to content

Count JS test pass/fails; return proper exit code#456

Merged
wohali merged 1 commit into
apache:masterfrom
wohali:3328-fix-js-test-runner
Mar 19, 2017
Merged

Count JS test pass/fails; return proper exit code#456
wohali merged 1 commit into
apache:masterfrom
wohali:3328-fix-js-test-runner

Conversation

@wohali

@wohali wohali commented Mar 17, 2017

Copy link
Copy Markdown
Member

Currently test/javascript/run always returns an exit code of 0,
regardless of whether any tests fail or not. This makes any sort of
automated testing that expects to inspect the results of the run
invalid.

make javascript should now properly fail if any of the JS tests fail.
It also prints a numerical summary of passed/failed tests, similar to
the eunit results.

Fixes COUCHDB-3328

@wohali

wohali commented Mar 18, 2017

Copy link
Copy Markdown
Member Author

Ironically, the failed Travis CI run shows exactly what I mean. I don't know if the failing JS test (test/javascript/tests/replication.js) fails only on R16B03 because we have a bug there, or because the test case is flaky. This demands further investigation - after we merge this change. :)

ETA: Restarting Travis fixed the failing test. We really need to fix our test suite :(

@michellephung

Copy link
Copy Markdown
Member

+1 \o/ passing tests

@wohali wohali merged commit d022ebe into apache:master Mar 19, 2017
nickva added a commit to nickva/couchdb that referenced this pull request Sep 7, 2022
Recently "info" field for running and pending states switched to having
replication stats instead of being `null`, so update documentation accordingly.

Related PR: apache#2292
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants