Fix leaked opened db handle in smoosh#6016
Merged
Merged
Conversation
rnewson
approved these changes
May 27, 2026
nickva
force-pushed
the
fix-smoosh-db-handle-leaking
branch
from
854b62b to
1149fbf
Compare
`smoosh_channel:maybe_remonitor_cpid/3` opened db and never closed it. That left a dangling reference (monitor to it) which prevented that db handle from becoming idle. We noticed this after inspecting dangling deleted fd handles which were still left open by something. That something turned to be smoosh_channel gen_server.
nickva
force-pushed
the
fix-smoosh-db-handle-leaking
branch
from
1149fbf to
dc72c84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
smoosh_channel:maybe_remonitor_cpid/3opened db and never closed it. That left a dangling reference (monitor to it) which prevented that db handle from becoming idle.We noticed this after inspecting dangling deleted fd handles which were still left open by something. That something turned to be smoosh_channel gen_server.