Skip to content

Fix leaked opened db handle in smoosh #6016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickva merged 1 commit into from
May 28, 2026
+21 −17
Merged

Fix leaked opened db handle in smoosh #6016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 21 additions & 17 deletions src/smoosh/src/smoosh_channel.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,27 +390,31 @@ maybe_remonitor_cpid(#state{} = State, DbName, Reason) when is_binary(DbName) ->
#state{name = Name, active = Active} = State,
case couch_db:open_int(DbName, []) of
{ok, Db} ->
try couch_db:get_compactor_pid_sync(Db) of
nil ->
LogMsg = "~s : exit for compaction of ~p: ~p",
LogArgs = [Name, smoosh_utils:stringify(DbName), Reason],
couch_log:warning(LogMsg, LogArgs),
re_enqueue(DbName),
State;
CPid when is_pid(CPid) ->
monitor(process, CPid),
Level = smoosh_utils:log_level("compaction_log_level", "notice"),
LogMsg = "~s: ~s compaction already running. Re-monitor Pid ~p",
LogArgs = [Name, smoosh_utils:stringify(DbName), CPid],
couch_log:Level(LogMsg, LogArgs),
State#state{active = Active#{DbName => CPid}}
try
case couch_db:get_compactor_pid_sync(Db) of
nil ->
LogMsg = "~s : exit for compaction of ~p: ~p",
LogArgs = [Name, smoosh_utils:stringify(DbName), Reason],
couch_log:warning(LogMsg, LogArgs),
re_enqueue(DbName),
State;
CPid when is_pid(CPid) ->
monitor(process, CPid),
Level = smoosh_utils:log_level("compaction_log_level", "notice"),
LogMsg = "~s: ~s compaction already running. Re-monitor Pid ~p",
LogArgs = [Name, smoosh_utils:stringify(DbName), CPid],
couch_log:Level(LogMsg, LogArgs),
State#state{active = Active#{DbName => CPid}}
end
catch
_:Error ->
LogMsg = "~s: error remonitoring db compaction ~p error:~p",
LogArgs = [Name, smoosh_utils:stringify(DbName), Error],
couch_log:warning(LogMsg, LogArgs),
ErrLogMsg = "~s: error remonitoring db compaction ~p error:~p",
ErrLogArgs = [Name, smoosh_utils:stringify(DbName), Error],
couch_log:warning(ErrLogMsg, ErrLogArgs),
re_enqueue(DbName),
State
after
couch_db:close(Db)
end;
Error = {not_found, no_db_file} ->
LogMsg = "~s : exit for compaction of ~p: ~p",
Expand Down