Handle errors better in index cleanup - #6081
Merged
Merged
Conversation
rnewson
approved these changes
Jul 29, 2026
Previously, if a node was down when cleaning up any indexes we'd get an
exception like:
```
{erpc,noconnection} : node@host
[<<"erpc:receive_response/3 L1442">>,<<"dreyfus_fabric_cleanup:recv/3 L54">>
[<<"erpc:receive_response/3 L1442">>,<<"dreyfus_fabric_cleanup:recv/3 L54">>,...
```
We can handle that better by anticipating a few more error conditions:
noconnection, exits, throws, timeouts.
To avoid copying the mess in three place let's just use a single helper
function in fabric.
Add tests for all the silly bits.
nickva
force-pushed
the
more-robust-cleaning
branch
from
July 29, 2026 13:52
1b838dd to
7bbd2a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if a node was down when cleaning up any indexes we'd get an exception like:
We can handle that better by anticipating a few more error conditions: noconnection, exits, throws, timeouts.
To avoid copying the mess in three place let's just use a single helper function in fabric.
Add tests for all the silly bits.