Bump deps (credo, elixir, meck) and fix Elixir tests - #6083
Merged
Conversation
Unfortunately (or fortinately) credo discovered a bunch of issues in the test suite. Those will be fixed in a separate commit.
After updating credo it showed a bunch of issues. FindConflicts was misnamed, some mango tests were copy pasted wrong. The test finder helper couldn't find mango tests since they are level lower and we didn't use a recursive search pattern. `pretty_print` had the wrong args order swapped when calling `map_join/3`. A few test helpers are not really tests so can just import what they need.
nickva
force-pushed
the
bump-dependencies
branch
from
July 30, 2026 21:41
4f20b47 to
3209f95
Compare
Warnings (not sure how long these have been around) showed some errors in the tests like unused variables, using strings keys instead of having to quote them. The duplicates in the mango tests were ported from Python but they are just noise as the last entry wins and if we want to test duplicate JSON behavior in Python or Elixir we should do that in a different test.
nickva
changed the title
big-r81
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update various helper deps: credo, elixir, meck
Unfortunately (or fortunately) credo discovered a bunch of issues in the tests. Those are fixed in a separate commit.
FindConflicts was misnamed, some mango tests were copy pasted wrong. The test finder helper couldn't find mango tests since they are level lower and we didn't use a recursive search pattern.
pretty_printhad the wrong args order swapped when callingmap_join/3. A few test helpers are not really tests so can just import what they need.Warnings (not sure how long these have been around) showed some errors in the tests like unused variables, using strings keys instead of having to quote them. The duplicates in the mango tests were ported from Python but they are just noise as the last entry wins and if we want to test duplicate JSON behavior in Python or Elixir we should do that in a different test.