base64:decode throws error:badarg too - #6090
Merged
Merged
Conversation
Contributor
|
I think it would be nice to cover this change with some test. |
rnewson
force-pushed
the
improve-invalid-auth-header-handling
branch
from
August 6, 2026 14:16
a503a4a to
4f487b9
Compare
Expand what errors when base64 decoding we handle
rnewson
force-pushed
the
improve-invalid-auth-header-handling
branch
from
August 6, 2026 15:27
4f487b9 to
3b59e2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Expand what errors when base64 decoding we handle
Testing recommendations
Try `curl http://localhost:5984/_all_dbs -H 'Authorization: Basic foo' etc.
Related Issues or Pull Requests
N/A
Checklist
rel/overlay/etc/default.inisrc/docsfolder