Pass user context when opening a doc in show handler - #788
Merged
Conversation
iilyak
approved these changes
Sep 4, 2017
iilyak
left a comment
iilyak
left a comment
Contributor
There was a problem hiding this comment.
Tests pass locally.
make javascript suites=users_db_security
test/javascript/tests/users_db_security.js pass
=======================================================
JavaScript tests complete.
Failed: 0. Skipped or passed: 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
A request to view's
_showsupposed to work on admin-only databases, such as_userswhen accessed with admin's privileges. This fix passes user context to fabric'sopen_docallowing this to happen.Testing recommendations
Included tests could be run as
make javascript suites=users_db_securityAlso "Steps to Reproduce" from issue #653 should now work as expected.
GitHub issue number
Fixes #653
Checklist