CURATOR-124 - PathChildrenCache StartMode documentation improvement #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 22, 2014 13:23
Updated PathChildrenCache.StartMode.NORMAL JavaDoc to accurately depict the cache startup behavior. Added test testChildrenInitializedNormal to assert the startup behavior indicated in the JavaDoc.
Updated BUILD_INITIAL_CACHE doc to indicate that the start() method with this mode will cause a synchronous rebuilding of the cache. Removed extra line.
Contributor
Author
|
Thanks for the feedback - I've pushed another commit to address your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
PathChildrenCache.StartMode.NORMALJavaDoc to accurately depict the cache startup behavior.Added test
testChildrenInitializedNormalto assert the startup behavior indicated in the JavaDoc.My IDE is also configured to remove trailing white space by default. If this is a problem I can remove those changes and resubmit.