Merged
Conversation
Before, regardless of the value set in `connectionTimeoutMs` the CuratorZookeeperClient#internalBlockUntilConnectedOrTimedOut method did the initial wait with value of 1 second, which made settings lower than this value ineffective. This proved problematic in several use cases where such minimum for timeout is prohibitively large.
Contributor
Author
|
I encountered this problem on one project I work on (using curator-framework 2.8.0). Could this change be possibly considered also for curator 2.x? |
Member
|
Please create a Jira issue for this per: https://cwiki.apache.org/confluence/display/CURATOR/Submitting+Pull+Requests |
Member
We're not doing 2.x releases anymore. It's EOL. |
Contributor
Author
|
@Randgalt thank you for the quick response. I created https://issues.apache.org/jira/browse/CURATOR-475 for this. Should I discard this PR and make a new one from a branch named CURATOR-475 now or we can somehow links this existing PR with the created JIRA? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, regardless of the value set in
connectionTimeoutMstheCuratorZookeeperClient#internalBlockUntilConnectedOrTimedOut method did
the initial wait with value of 1 second, which made settings lower than
this value ineffective. This proved problematic in several use cases
where such minimum for timeout is prohibitively large.