CURATOR-593: Append chroot for EnsembleProvider::setConnectionString in EnsembleTracker#460
Merged
kezhuw merged 2 commits intoapache:masterfrom May 23, 2023
Conversation
…in EnsembleTracker Curator uses `EnsembleProvider::getConnectionString` as connection string to `ZooKeeper`. `EnsembleTracker` subscribes to config node to construct up to date connection string for `EnsembleProvider`. This is great. But, currently, `EnsembleTracker` omits chroot part of connection string which could cause curator locating at ZooKeeper root after reconnection. This could damage clients' data hierarchy in unexpected manner.
tisonkun
reviewed
May 21, 2023
Member
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Thanks for taking care of this issue. One question for EnsembleTracker. Other comments are about style.
curator-framework/src/test/java/org/apache/curator/framework/imps/TestReconfiguration.java
Outdated
Show resolved
Hide resolved
curator-framework/src/main/java/org/apache/curator/framework/imps/EnsembleTracker.java
Show resolved
Hide resolved
curator-framework/src/test/java/org/apache/curator/framework/imps/TestReconfiguration.java
Outdated
Show resolved
Hide resolved
…String in EnsembleTracker
tisonkun
approved these changes
May 23, 2023
tisonkun
reviewed
May 23, 2023
curator-framework/src/main/java/org/apache/curator/framework/imps/EnsembleTracker.java
Show resolved
Hide resolved
Member
Author
|
Thank you for your reviewing. @tisonkun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Curator uses
EnsembleProvider::getConnectionStringas connection string toZooKeeper.EnsembleTrackersubscribes to config node to construct up to date connection string forEnsembleProvider. This is great.But, currently,
EnsembleTrackeromits chroot part of connection string which could cause curator locating at ZooKeeper root after reconnection. This could damage clients' data hierarchy in unexpected manner.