CURATOR-677: Complete BackgroundCallback if sub operation failed or cancelled#467
Merged
kezhuw merged 2 commits intoapache:masterfrom Aug 15, 2023
Conversation
…ancelled Currently, some background operations use auxiliary sub operations to complete task in case of primary conditions are not satisfied. But most of these sub operations count only success path, so they will hang `BackgroundCallback` if they are failed or cancelled due to framework closed. This is the leftover of [CURATOR-673][](apache#464). [CURATOR-673]: https://issues.apache.org/jira/browse/CURATOR-673
kezhuw
commented
Jun 12, 2023
Member
Author
kezhuw
left a comment
kezhuw
left a comment
There was a problem hiding this comment.
I deliberately split this pr into two commits, first for test case and second for code fix. Most newly added tests could not even resist one run in "repeat until failure" mode. All new tests resist 100 runs without failure in local.
| if (!client.getZookeeperClient().getRetryPolicy().allowRetry(e)) { | ||
| sendBackgroundResponse( | ||
| client, e.code().intValue(), e.getPath(), null, null, null, mainOperationAndData); | ||
| throw e; |
Member
Author
There was a problem hiding this comment.
These two statements will complete twice of BackgroundCallback. abortOperation introduced in #464 will complete this anyway.
Besides above, the deleted call omitted OperationAndData.context.
| statCallback, | ||
| backgrounding.getContext()); | ||
| } catch (KeeperException e) { | ||
| // ignore |
Member
Author
There was a problem hiding this comment.
I don't know how this could happen. But if it happen in real, it should go to exception path instead of ignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, some background operations use auxiliary sub operations to
complete task in case of primary conditions are not satisfied. But most
of these sub operations count only success path, so they will hang
BackgroundCallbackif they are failed or cancelled due to frameworkclosed.
This is the leftover of CURATOR-673(#464).