Support for unsigned token - #54
Conversation
coheigea
left a comment
There was a problem hiding this comment.
I think that "doNotEnforceAssertionsSigned" should only apply to encrypted assertions. I don't see a use-case for supporting unsigned and unencrypted assertions.
Then maybe the doNotEnforceAssertionSigned in configuration is not necessary at all and replace its "logic" with checks to the token. Assertion signature check whould be disabled when it is crypted and unsigned. What do you think ? |
|
No, I still think we should always default to requiring a signed token, even if it's encrypted. |
coheigea
left a comment
There was a problem hiding this comment.
A minor change which I'll do myself is that it should check the signature in all cases (even if not required).
No description provided.