Properly handle nested arrays in json parsing#3168
Merged
Conversation
reta
approved these changes
Jun 2, 2026
coheigea
added a commit
that referenced
this pull request
Jun 2, 2026
* Properly handle nested arrays in json parsing * Fixup (cherry picked from commit 2dff320)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was a bug in the JSON parser when it read arrays inside arrays.
Before the fix:
It knew how to handle objects inside a list, like [{"a":1}].
But it did not handle nested lists, like [[]] or [[1,2]].
So it tried to read the inner list as if it were a number/text value.
That caused an unexpected NumberFormatException crash.