Skip to content

Properly handle nested arrays in json parsing #3168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coheigea merged 2 commits into from
Jun 2, 2026
+24 −0
Merged

Properly handle nested arrays in json parsing #3168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bb5f6f
Properly handle nested arrays in json parsing
coheigea Jun 2, 2026
39b1888
Fixup
coheigea Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions ...s/json-basic/src/main/java/org/apache/cxf/jaxrs/json/basic/JsonMapObjectReaderWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,13 +245,15 @@ private void readJsonObjectAsSettable(Settable values, String json, int depth) {
}
if (json.charAt(sepIndex + j) == OBJECT_START) {
int closingIndex = getClosingIndex(json, OBJECT_START, OBJECT_END, sepIndex + j);
closingIndex = requireClosingIndex(closingIndex, OBJECT_START, OBJECT_END);
String newJson = json.substring(sepIndex + j + 1, closingIndex);
MapSettable nextMap = new MapSettable();
readJsonObjectAsSettable(nextMap, newJson, depth + 1);
values.put(name, nextMap.map);
i = closingIndex + 1;
} else if (json.charAt(sepIndex + j) == ARRAY_START) {
int closingIndex = getClosingIndex(json, ARRAY_START, ARRAY_END, sepIndex + j);
closingIndex = requireClosingIndex(closingIndex, ARRAY_START, ARRAY_END);
String newJson = json.substring(sepIndex + j + 1, closingIndex);
values.put(name, internalFromJsonAsList(name, newJson, depth + 1));
i = closingIndex + 1;
Expand Down Expand Up @@ -281,10 +283,16 @@ private List<Object> internalFromJsonAsList(String name, String json, int depth)
}
if (json.charAt(i) == OBJECT_START) {
int closingIndex = getClosingIndex(json, OBJECT_START, OBJECT_END, i);
closingIndex = requireClosingIndex(closingIndex, OBJECT_START, OBJECT_END);
MapSettable nextMap = new MapSettable();
readJsonObjectAsSettable(nextMap, json.substring(i + 1, closingIndex), depth + 1);
values.add(nextMap.map);
i = closingIndex + 1;
} else if (json.charAt(i) == ARRAY_START) {
int closingIndex = getClosingIndex(json, ARRAY_START, ARRAY_END, i);
closingIndex = requireClosingIndex(closingIndex, ARRAY_START, ARRAY_END);
values.add(internalFromJsonAsList(name, json.substring(i + 1, closingIndex), depth + 1));
Comment thread
coheigea marked this conversation as resolved.
i = closingIndex + 1;
} else {
int commaIndex = getCommaIndex(json, i);
Object value = readPrimitiveValue(name, json, i, commaIndex);
Expand Down Expand Up @@ -339,6 +347,15 @@ protected static int getClosingIndex(String json, char openChar, char closeChar,
return closingIndex;
}

private static int requireClosingIndex(int closingIndex, char openChar, char closeChar) {
if (closingIndex == -1) {
throw new UncheckedIOException(new IOException(
"Error in parsing json: missing closing '" + closeChar
+ "' for '" + openChar + "'"));
}
return closingIndex;
}

protected static int getNextSepCharIndex(String json, char curlyBracketChar, int from) {
int nextCurlyBracketIndex = -1;
boolean inString = false;
Expand Down
7 changes: 7 additions & 0 deletions ...on-basic/src/test/java/org/apache/cxf/jaxrs/json/basic/JsonMapObjectReaderWriterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,13 @@ public void testRejectNaNNumericValue() {
assertInvalidNumericLiteral("NaN");
}

@Test
public void testNestedArrayValueParsesSuccessfully() {
Map<String, Object> map = new JsonMapObjectReaderWriter().fromJson("{\"a\":[[]]}");
assertEquals(1, map.size());
assertEquals(Collections.singletonList(Collections.emptyList()), map.get("a"));
}

private void assertInvalidNumericLiteral(String value) {
JsonMapObjectReaderWriter jsonMapObjectReaderWriter = new JsonMapObjectReaderWriter();
try {
Expand Down
Loading