Skip to content

View Launch Options#26

Merged
jw3 merged 1 commit intoapache:mainfrom
shanedell:launch-configs
Nov 4, 2021
Merged

View Launch Options#26
jw3 merged 1 commit intoapache:mainfrom
shanedell:launch-configs

Conversation

@shanedell
Copy link
Copy Markdown
Contributor

Added three options for opening up the different views automatically on debug start

New Launch Options:

  • openHexView -- When set to true tells the extension to open up the Hex View on debug start
  • openInfosetView -- When set to true tells the extension to open up the Infoset View on debug start
  • openInfosetDiffView -- When set to true tells the extension to open up the Infoset Diff View on debug start

Closes #13

Copy link
Copy Markdown
Contributor

@mbeckerle mbeckerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@stevedlawrence
Copy link
Copy Markdown
Member

+1, but I'd prefer to see a +1 from @jw3 before this is merged

Comment thread .gitignore Outdated
Comment thread src/hexView.ts Outdated
Comment thread yarn.lock
@stevedlawrence
Copy link
Copy Markdown
Member

We try to avoid merge commits in pull requests. They make it difficult to reason about history and make some other things like git bisect a bit more difficult. Please squash this all into a single commit before this can be merged.

@shanedell
Copy link
Copy Markdown
Contributor Author

Okay that makes I apologize for that

@jw3 jw3 merged commit 319b99e into apache:main Nov 4, 2021
@shanedell shanedell deleted the launch-configs branch November 4, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Layout preferences

5 participants