ci: gate TPC-H workflow on rust-only path allow list#1755
Merged
Conversation
Switch the TPC-H workflow from a `paths-ignore` deny list to a `paths` allow list so it only runs when something that can actually affect the benchmark changes: Cargo workspace crates, root Cargo manifests/lock, the pinned Rust toolchain, the workflow itself, and the shared setup-builder action. Python bindings, docs, other workflows, and dev tooling no longer trigger the run.
milenkovicm
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of apache/datafusion#22455.
Rationale for this change
The TPC-H workflow currently uses a
paths-ignoredeny list that only excludes a few obvious doc paths, so it still runs for changes that cannot affect the benchmark (e.g. Python bindings, other workflows, dev tooling). An allow list makes the trigger intent explicit and avoids wasted CI minutes on irrelevant changes.What changes are included in this PR?
Switches the
pushandpull_requesttriggers in.github/workflows/tpch.ymlfrompaths-ignoretopaths. The allow list is scoped to what the workflow actually builds and runs:ballista/**— scheduler, executor, core, client (built asballista-schedulerandballista-executor)benchmarks/**—ballista-benchmarksand thetpchdriverCargo.toml,Cargo.lockrust-toolchain.tomlsetup-builderaction it consumesThe Python crate (
python/, excluded from the workspace),ballista-cli/,examples/, docs, other workflows, and dev tooling no longer trigger the run.Are there any user-facing changes?
No.