ci: use maturin sdist subcommand to avoid building a wheel#1759
Merged
Conversation
maturin build --sdist produces both a source distribution and a wheel, which trips the assertion that the sdist job must not generate wheels. Switch to the dedicated maturin sdist subcommand so only the .tar.gz artifact is produced; the --release and --strip flags are wheel-only and have no meaning for sdist.
andygrove
added a commit
that referenced
this pull request
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
The Python Release Build's "Source distribution" job runs
maturin build --release --sdist --out dist --strip. Thematurin buildsubcommand produces a wheel even when--sdistis passed, so the job ends up emitting both a wheel and the sdist. This trips the "Assert sdist build does not generate wheels" step that was added in #1753, e.g. https://github.com/apache/datafusion-ballista/actions/runs/26345525629/job/77555535891:(The assertion previously looked in
target/wheelsrather thanpython/dist, so the same misbuild silently slipped through.)What changes are included in this PR?
Switch the sdist job's build command to the dedicated
maturin sdist --out distsubcommand, which only produces a.tar.gz. The--releaseand--stripflags only apply to wheel builds and are dropped.Are there any user-facing changes?
No.