chore: fix clippy warnings for Rust 1.93 #3239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use local `root_op` variable instead of unwrapping `exec_context.root_op` - Replace `is_some()` + `unwrap()` pattern with `if let Some(...)` Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
mbutrovich
changed the title
mbutrovich
approved these changes
Jan 22, 2026
Contributor
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
LGTM, thanks @andygrove!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3239 +/- ##
============================================
+ Coverage 56.12% 60.04% +3.92%
- Complexity 976 1418 +442
============================================
Files 119 170 +51
Lines 11743 15774 +4031
Branches 2251 2606 +355
============================================
+ Hits 6591 9472 +2881
- Misses 4012 4981 +969
- Partials 1140 1321 +181 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
unwrap()would always panic by using localroot_opvariable directlyis_some()+unwrap()patterns with idiomaticif let Some(...)in two locationsThese issues were introduced by new clippy rules in Rust 1.93.
Test plan
cargo clippy --all-targetspasses with Rust 1.93.0🤖 Generated with Claude Code