-
Notifications
You must be signed in to change notification settings - Fork 278
build: reduce overhead of fuzz testing #3257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: reduce overhead of fuzz testing #3257
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3257 +/- ##
============================================
+ Coverage 56.12% 60.13% +4.00%
- Complexity 976 1457 +481
============================================
Files 119 175 +56
Lines 11743 16085 +4342
Branches 2251 2665 +414
============================================
+ Hits 6591 9672 +3081
- Misses 4012 5066 +1054
- Partials 1140 1347 +207 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| java_version: "17" | ||
| maven_opts: "-Pspark-4.0" | ||
| scan_impl: "native_comet" | ||
| scan_impl: "auto" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have only been testing Spark 4 with the native_comet scan as the default 🤦
mbutrovich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andygrove!
Which issue does this PR close?
N/A
Rationale for this change
CI runs the PR builds with the default native scan implementation specified in the workflow, for example:
In
CometFuzzTestBase, we were running each test once for each scan implementation. This was redundant.What changes are included in this PR?
CometFuzzTestBaseuses the default scan impl.automode. This was missing.How are these changes tested?