test: increase test coverage for non-native_comet scan implementations #3258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plementations The "test multiple pages with different sizes and nulls" test previously used negative values for unsigned integer Parquet types (UINT_8, UINT_16, UINT_32, UINT_64), which required native_comet to handle correctly. This limited test coverage to only the native_comet scan implementation. This change: - Modifies the test to use valid unsigned values (non-negative) so it can run with any scan implementation (native_datafusion, native_iceberg_compat) - Extracts the invalid unsigned value handling into a dedicated test "native_comet reads unsigned int types with values exceeding signed range" that explicitly tests native_comet's ability to handle these edge cases Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3258 +/- ##
============================================
+ Coverage 56.12% 60.07% +3.94%
- Complexity 976 1437 +461
============================================
Files 119 172 +53
Lines 11743 15926 +4183
Branches 2251 2631 +380
============================================
+ Hits 6591 9567 +2976
- Misses 4012 5031 +1019
- Partials 1140 1328 +188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
changed the title
Modify makeParquetFileAllPrimitiveTypes to generate valid unsigned values (non-negative) for UINT fields instead of negative values. This allows tests using this function to work with any scan implementation. Changes: - UINT_8: use Math.abs(i) % 256 instead of (-i).toByte - UINT_16: use Math.abs(i) % 65536 instead of (-i).toShort - UINT_32: use Math.abs(i) instead of -i - UINT_64: use Math.abs(i.toLong) instead of (-i).toLong Remove explicit native_comet scan setting from CometExpressionSuite tests: - round - hex - test integral divide Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ants Remove explicit native_comet scan setting from additional tests: - basic data type support - uint data type support Delete redundant "excluding u8/u16" test variants since the data generator now produces valid unsigned values that work with all scan implementations. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
andygrove
commented
Jan 23, 2026
|
|
||
| test("test integral divide") { | ||
| // this test requires native_comet scan due to unsigned u8/u16 issue | ||
| withSQLConf(CometConf.COMET_NATIVE_SCAN_IMPL.key -> CometConf.SCAN_NATIVE_COMET) { |
Member
Author
There was a problem hiding this comment.
integral divide tests should not be specific to native_comet
andygrove
commented
Jan 23, 2026
| withTempDir { dir => | ||
| val path = new Path(dir.toURI.toString, "hex.parquet") | ||
| // this test requires native_comet scan due to unsigned u8/u16 issue | ||
| withSQLConf(CometConf.COMET_NATIVE_SCAN_IMPL.key -> CometConf.SCAN_NATIVE_COMET) { |
Member
Author
There was a problem hiding this comment.
hex tests should not be specific to native_comet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
We have many tests that explicitly specify
native_cometscan. This means we do not get coverage with other scan implementations when CI overrides the default scan implementation.What changes are included in this PR?
native_cometin some testsHow are these changes tested?