feat: Enable native columnar-to-row by default #3299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3299 +/- ##
============================================
+ Coverage 56.12% 59.95% +3.82%
- Complexity 976 1473 +497
============================================
Files 119 175 +56
Lines 11743 16167 +4424
Branches 2251 2682 +431
============================================
+ Hits 6591 9693 +3102
- Misses 4012 5126 +1114
- Partials 1140 1348 +208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add support for native columnar-to-row conversion in Spark SQL tests: - SparkPlanSuite: Handle CometNativeColumnarToRowExec in SPARK-37779 test - BucketedReadSuite: Handle CometNativeColumnarToRowExec when extracting join operators from execution plans This fixes test failures when native C2R is enabled by default. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add support for native columnar-to-row conversion in Spark SQL tests: - SparkPlanSuite: Handle CometNativeColumnarToRowExec in SPARK-37779 test - BucketedReadSuite: Handle CometNativeColumnarToRowExec when extracting join operators from execution plans This fixes test failures when native C2R is enabled by default. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add support for native columnar-to-row conversion in Spark SQL tests: - SparkPlanSuite: Handle CometNativeColumnarToRowExec in SPARK-37779 test - BucketedReadSuite: Handle CometNativeColumnarToRowExec when extracting join operators from execution plans This fixes test failures when native C2R is enabled by default. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
andygrove
changed the title
Skip WholeStageCodegenSuite tests when Comet is enabled, matching the behavior in Spark 3.5. This fixes test failures like "Sort should be included in WholeStageCodegen" when native C2R is enabled. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
andygrove
commented
Jan 27, 2026
| // Disable AQE because the WholeStageCodegenExec is added when running QueryStageExec | ||
| class WholeStageCodegenSuite extends QueryTest with SharedSparkSession | ||
| - with DisableAdaptiveExecutionSuite { | ||
| + with DisableAdaptiveExecutionSuite with IgnoreCometSuite { |
Member
Author
There was a problem hiding this comment.
This matches what we were already doing for 3.5
comphead
reviewed
Jan 28, 2026
Co-authored-by: Oleks V <comphead@users.noreply.github.com>
comphead
approved these changes
Jan 28, 2026
Contributor
There was a problem hiding this comment.
Thanks @andygrove would be a nice note on the release notes
vigneshsiva11
pushed a commit
to vigneshsiva11/datafusion-comet
that referenced
this pull request
Jan 29, 2026
mbutrovich
added a commit
to mbutrovich/datafusion-comet
that referenced
this pull request
Jan 29, 2026
This reverts commit 22fdec9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3300
Rationale for this change
Enable by default for better performance and reduced GC for JVM shuffle where the child plan is a Comet plan.
What changes are included in this PR?
How are these changes tested?