fix: use -status:failure for pending PR filter#3359
Closed
andygrove wants to merge 1 commit intoapache:mainfrom
Closed
fix: use -status:failure for pending PR filter#3359andygrove wants to merge 1 commit intoapache:mainfrom
andygrove wants to merge 1 commit intoapache:mainfrom
Conversation
Skipped CI checks (e.g. iceberg matrix jobs) cause `status:success` to exclude PRs that have all checks passing. Using `-status:failure` instead includes PRs where no checks have failed, which is the intended behavior. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
status:successwhich excludes PRs where skipped checks (e.g. iceberg matrix jobs with unexpanded variables) prevent GitHub from reporting overall status as "success"-status:failureso PRs are included unless they have actually failing checksTest plan
native_cometas a valid option forCOMET_NATIVE_SCAN_IMPLconfig #3358 that were previously excluded🤖 Generated with Claude Code