Skip to content

Conversation

@EmilyMatt
Copy link
Contributor

@EmilyMatt EmilyMatt commented Feb 3, 2026

Which issue does this PR close?

Towards #3554

Rationale for this change

A smaller change, These were just in the main shuffle directory, and are not even specifically tied the shuffle.
Moved them all into a specific directory.

What changes are included in this PR?

Just moved them into a directory, reduced visibility of a couple of functions

How are these changes tested?

By the current tests

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EmilyMatt

@andygrove
Copy link
Member

@EmilyMatt looks like you need to run cargo fmt on this one

@EmilyMatt
Copy link
Contributor Author

@andygrove My bad, added the mod statement later

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.99%. Comparing base (f09f8af) to head (dafe646).
⚠️ Report is 919 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3373      +/-   ##
============================================
+ Coverage     56.12%   59.99%   +3.86%     
- Complexity      976     1464     +488     
============================================
  Files           119      175      +56     
  Lines         11743    16165    +4422     
  Branches       2251     2681     +430     
============================================
+ Hits           6591     9698    +3107     
- Misses         4012     5114    +1102     
- Partials       1140     1353     +213     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove andygrove merged commit 7f7ad74 into apache:main Feb 3, 2026
124 checks passed
@EmilyMatt EmilyMatt deleted the spark_unsafe branch February 3, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants