Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Improves SQL test failure diagnostics by including the originating .sql file and 1-based line number (plus the SQL text) in assertion failure output for SLT runs.
Changes:
- Extend
SqlStatementandSqlQueryrecords to carry the starting line number of the SQL text. - Update
SqlFileTestParserto compute and store the start line for each statement/query. - Update
CometSqlFileTestSuiteto wrap execution with clues that surfacerelativePath:lineand the SQL being executed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| spark/src/test/scala/org/apache/comet/SqlFileTestParser.scala | Track per-record start line numbers when parsing SQL test files. |
| spark/src/test/scala/org/apache/comet/CometSqlFileTestSuite.scala | Include file/line + SQL text in failure output via withClue. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andygrove
approved these changes
Feb 4, 2026
Member
andygrove
left a comment
There was a problem hiding this comment.
This is a nice improvement! Thanks @peterxcli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3388.
Rationale for this change
show the exact file and line location of the sql that cause error in slt. so the user will be easier identify the problem.
What changes are included in this PR?
only the sql test suit and the sql test parser.
How are these changes tested?