chore: Array literals tests enable#3633
Merged
comphead merged 5 commits intoapache:mainfrom Mar 7, 2026
Merged
Conversation
comphead
commented
Mar 7, 2026
| spark.sql(sql) | ||
| } | ||
| } catch { | ||
| case e: Exception => |
Contributor
Author
There was a problem hiding this comment.
output the failed SQL that causes the file to fail
comphead
commented
Mar 7, 2026
| -- specific language governing permissions and limitations | ||
| -- under the License. | ||
|
|
||
| -- Config: spark.comet.expression.ArrayInsert.allowIncompatible=true |
Contributor
Author
There was a problem hiding this comment.
Spark 4.0 classname is ArrayInsert, in earlier versions ArrayAppend
andygrove
approved these changes
Mar 7, 2026
andygrove
reviewed
Mar 7, 2026
| } | ||
| } catch { | ||
| case e: Exception => | ||
| sys.error(s"Error executing SQL '$sql'. Reason: '${e.getMessage}''") |
Member
There was a problem hiding this comment.
The original exception stack trace gets consumed. Would it be better to rethrow?
Suggested change
| sys.error(s"Error executing SQL '$sql'. Reason: '${e.getMessage}''") | |
| throw new RuntimeException(s"Error executing SQL '$sql'", e) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3338 .
Rationale for this change
What changes are included in this PR?
How are these changes tested?