chore: Experiments with native_datafusion scan optimizations#3755
Draft
comphead wants to merge 6 commits intoapache:mainfrom
Draft
chore: Experiments with native_datafusion scan optimizations#3755comphead wants to merge 6 commits intoapache:mainfrom
native_datafusion scan optimizations#3755comphead wants to merge 6 commits intoapache:mainfrom
Conversation
andygrove
reviewed
Mar 22, 2026
Comment on lines
+119
to
+120
| // Pre-compute lowercased physical field names to avoid repeated | ||
| // to_lowercase() calls in the O(n*m) matching loop. |
Member
There was a problem hiding this comment.
Is there any chance we could use eq_ignore_ascii_case to avoid allocating the lower case strings?
Contributor
Author
|
Not sure why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #3748
Rationale for this change
This PR addresses some low hanging fruits with
native_datafusionscans:O(n*m)schema case sensitive transformation calls, in call stack currently I can seewhich allocates 1M times when doing case-sensitive transformation in schema adapter for 20K rows with deeply nested schema
What changes are included in this PR?
How are these changes tested?