test: Port DateTimeUtilsSuite timestamp format tests in Comet#3780
Merged
parthchandra merged 2 commits intoapache:mainfrom Mar 24, 2026
Merged
test: Port DateTimeUtilsSuite timestamp format tests in Comet#3780parthchandra merged 2 commits intoapache:mainfrom
parthchandra merged 2 commits intoapache:mainfrom
Conversation
andygrove
approved these changes
Mar 24, 2026
Member
andygrove
left a comment
andygrove
left a comment
There was a problem hiding this comment.
Nice tests. Thanks @parthchandra
Contributor
Author
They're Spark tests :) |
Contributor
Author
|
Merged. Thank you @andygrove ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes # #3776
Rationale for this change
Spark
DateTimeUtilsSuitehas many useful tests for string to date and string to timestamp casts which are not being called because they are in the sql/catalyst subproject and are not part of Comet CI.What changes are included in this PR?
Adds a new test suite to replicate the relevant tests in Comet. The tests pass because the string to timestamp casts are currently marked as invalid and we fall back to Spark. Once all string formats are implemented and the casts are not marked incompatible, these tests will test the native implementation.
The tests currently use
checkSparkAnswerand once all formats are supported the tests can be changed to usecheckSparkAnswerAndOperatorHow are these changes tested?
By running the tests themselves.