fix: checkSparkAnswer displays incorrect labels#3927
Merged
andygrove merged 1 commit intoapache:mainfrom Apr 13, 2026
Merged
Conversation
andygrove
approved these changes
Apr 10, 2026
Member
andygrove
left a comment
andygrove
left a comment
There was a problem hiding this comment.
Thanks @parthchandra. This issue has annoyed me for a long time!
Contributor
|
You are a savior @parthchandra !👍 |
Contributor
Author
|
Thanks @andygrove, @coderfender @comphead. I did this because I misread (I should have known better) the results and went down a rabbit hole. Hopefully this will save others in future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
If a unit test fails because Comet's answer does not match Spark's answer, we print the wrong label in the output, labelling Comet's answer as Spark's answer. This is because we directly use Spark's
checkAnswerwhich uses the label 'Spark's Answer'.This is misleading and annoying.
What changes are included in this PR?
Implements a copy of Spark's checkAnswer with the right label.
How are these changes tested?
Added a ignored test that fails.