fix: fix decimal div and add tests#3952
Merged
parthchandra merged 5 commits intoapache:mainfrom Apr 17, 2026
Merged
Conversation
andygrove
reviewed
Apr 17, 2026
| SELECT cast(10 as decimal(18,0)) div cast(0.000000 as decimal(18,6)) | ||
|
|
||
| -- ============================================================================ | ||
| -- TRY mode: try_divide returns NULL even when ANSI is enabled globally |
Member
There was a problem hiding this comment.
Could you add a try_divide overflow case
Contributor
Author
|
Merged. Thank you @andygrove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes # #1526
Rationale for this change
Adds one fix in decimal div and adds additional tests
What changes are included in this PR?
Fixes decimal div for the Ansi path. Also adds sql file tests
How are these changes tested?
Existing and new tests